Clean up unused or unnecessary dependencies #283
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peterbom
commented
Nov 1, 2023
peterbom
commented
Nov 1, 2023
|
💡 This looks great to me, I can surely take a look bit more, but just for idea sake, shall we merge this after tcpDump work - and cut a separate release branch and then merge this. |
peterbom
force-pushed
the
feature/cleanup-deps
branch
from
5d79309
to
60a3d44
Compare
peterbom
commented
Nov 2, 2023
This reverts commit fae6364.
Tatsinnit
approved these changes
Nov 8, 2023
There was a problem hiding this comment.
🎊🙏 Looks good, thank you! worth test which we all can chip in, fyi @hsubramanianaks for viz
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The first part of #286.
Removes most of the dependencies identified by depcheck as being unused.
The
depchecktool also identified some missing dependencies, includingtslint. Tslint is now deprecated in favour ofeslint, so this also converts the project toeslint. No linting is done as part of any build scripts or pipelines, but there is now an npm script to run it manually. I'll create a separate issue to enable automated linting.The
utilsdependency was there to support the 'promisification' of node'sfslibrary. This is now unnecessary thanks to the inbuiltfs/promiseslibrary.This also removes some redundant processing from the webpack configuration.